Mod 9702 add button component to cards #163
Conversation
updated button for cardcomponent
|
you'll also have to update the version in package.json |
components/cards/CardButton.jsx
Outdated
| className={`card__button--secondary ${variantMapper[variant]} ${customClassName}`} | ||
| aria-label={`${text}`} | ||
| disabled={disabled} | ||
| onKeyUp={(e) => handleKeyUp(e)} | ||
| onClick={action}> | ||
| {text || children} | ||
| </button> | ||
| </button> */} | ||
| <Button onKeyUp={(e) => handleKeyUp(e)} onClick={action} copy={text || children} buttonTitle={text || children} buttonSize="md" buttonType="primary" backgroundColor="light" /> |
There was a problem hiding this comment.
i would think you would need to pass in the buttonType here? are they all primary buttons?
|
do you think the intention of this ticket is to replace these with 'Button' too?
|
|
this is what the homepage looks like
|
|
yeah, I added the buttons then make sure the styling matches, then Ill get rid of the other button |
|
Most of the styling additional styling is on usas |
data-transparency-ui-5.4.0.tgz
Outdated
| onClick={action}> | ||
| {text || children} | ||
| </button> | ||
| <Button onKeyUp={(e) => handleKeyUp(e)} onClick={action} copy={text || children} buttonTitle={text || children} buttonSize="md" buttonType={variantMapper[variant] === undefined ? "secondary" : variantMapper[variant]} backgroundColor="light" textAlignment="center" /> |
There was a problem hiding this comment.
are they always medium sized?
Check List Before Merging
Author
/docs)/dist)👆These can be done by executing
npm run buildand committing the build artifacts./index.js(if applicable)(if applicable)(if applicable)index.d.tsupdated with new prop types defined for new components.(if applicable)Reviewer