Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another authlib migration related changes #1858

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Another authlib migration related changes #1858

merged 4 commits into from
Dec 5, 2024

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Dec 5, 2024

  • Fix alembic.ini to work in dev container
  • Remove unique constraint from username
  • Update username when authenticating user

Zlopez added 3 commits December 5, 2024 17:50
@Zlopez
Make alembic.ini work with dev container
d6ecf4a 
Signed-off-by: Michal Konecny <[email protected]>
@Zlopez
Remove unique constraint from username
aa1aef3 
With authlib we just need to have unique e-mail and we don't care about
username anymore.

This will prevent crash when the username exists in database but with
different e-mail. Let this be handled by third party authentication systems.

Signed-off-by: Michal Konecny <[email protected]>
@Zlopez
Update the username when authenticating user
8109057 
If the user with e-mail exists update his username.

Signed-off-by: Michal Konecny <[email protected]>
@Zlopez Zlopez requested a review from a team as a code owner December 5, 2024 16:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/3a5dc2deb10d4b4891d8427a5966f0b4

✔️ fi-tox-mypy SUCCESS in 4m 38s
✔️ fi-tox-lint SUCCESS in 4m 51s
❌ fi-tox-format FAILURE in 4m 44s
✔️ fi-tox-python310 SUCCESS in 7m 26s
✔️ fi-tox-python311 SUCCESS in 8m 14s
✔️ fi-tox-python312 SUCCESS in 8m 19s
✔️ fi-tox-docs SUCCESS in 5m 09s
✔️ fi-tox-bandit SUCCESS in 4m 54s
❌ fi-tox-diff-cover FAILURE in 9m 05s

@Zlopez Zlopez changed the title Anothe authlib migration related changes Another authlib migration related changes Dec 5, 2024
@Zlopez
Fix tests
2350386 
Signed-off-by: Michal Konecny <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/9c592192593b4dd4bf7303a12effc875

✔️ fi-tox-mypy SUCCESS in 5m 04s
✔️ fi-tox-lint SUCCESS in 4m 45s
✔️ fi-tox-format SUCCESS in 4m 06s
✔️ fi-tox-python310 SUCCESS in 8m 04s
✔️ fi-tox-python311 SUCCESS in 7m 37s
✔️ fi-tox-python312 SUCCESS in 7m 56s
✔️ fi-tox-docs SUCCESS in 5m 38s
✔️ fi-tox-bandit SUCCESS in 4m 48s
✔️ fi-tox-diff-cover SUCCESS in 8m 39s

@Zlopez Zlopez merged commit 575883d into fedora-infra:master Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deployed:prod deployed:staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zlopez