[Feature] Allow admins to delete users from db #1735
Conversation
Signed-off-by: freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 5m 40s |
|
I'm taking care of the failing CI |
|
I will wait till CI will be fixed, but the PR looks good 👍 |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 7m 14s |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 7m 33s |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 6m 53s |
|
@Zlopez, I fixed the failing CIs, This PR is now ready for review |
pyproject.toml
Outdated
| @@ -119,6 +119,8 @@ Werkzeug = "3.0.1" | |||
| toml = "^0.10.2" | |||
| webargs = "^8.2.0" | |||
| WTForms = "^3.0.1" | |||
| attr = "^0.3.2" | |||
There was a problem hiding this comment.
Why adding those two dependencies? I don't see them imported anywhere.
There was a problem hiding this comment.
From the Tox-docs CI, There was an issue with filters.py inside /workspace/src/github.com/fedora-infra/anitya/.tox/docs/lib/python3.11/site-packages/attr/. This problem is occurring during an attempt to install idna, and attrs using Poetry.
To fix that issue I installed manually both dependencies.
There was a problem hiding this comment.
This isn't related to Anitya project but it's issue in dependencies of pip or poetry. Those shouldn't be in the dependencies for Anitya as we don't use them. We should only update poetry.lock file.
There was a problem hiding this comment.
Let me do that in separate PR.
There was a problem hiding this comment.
The PR is now available #1740. Could you remove changes in poetry.lock and pyproject.toml from this PR.
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 7m 32s |
|
I also noticed that the news file is missing. |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 5m 54s |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 6m 27s |
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 5m 26s |
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 5m 18s |
Signed-off-by: freedisch <[email protected]>
|
Build succeeded. ✔️ fi-tox-mypy SUCCESS in 6m 40s |
|
Thanks for the PR :-) |
Description
This PR fixes issue #931
This PR introduces a new delete button to users on user management page, allowing admin to delete users
Demo
Screen.Recording.2024-03-11.at.20.03.28.mov