Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit workflow #1703

Closed
wants to merge 7 commits into from
Closed

Fix pre-commit workflow #1703

wants to merge 7 commits into from

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Jan 11, 2024

Running the pre-commit locally didn't caused the issues that I see in the github actions, maybe removing the versions constraints can fix that.

@Zlopez
Fix pre-commit workflow
95a41e4 
Running the pre-commit locally didn't caused the issues that I see in the github
actions, maybe removing the versions constraints can fix that.

Signed-off-by: Michal Konecny <[email protected]>
@Zlopez Zlopez requested a review from a team as a code owner January 11, 2024 10:10
Zlopez added 3 commits January 11, 2024 11:16
@Zlopez
Run the pre-commit manually in GitHub action
905d072 
The prepared GitHub action for pre-commit doesn't work well in our environment.
Let's call it the same way as we do it locally.

Signed-off-by: Michal Konecny <[email protected]>
@Zlopez
Run pre-commit using poetry in github action
8c4711c 
Signed-off-by: Michal Konecny <[email protected]>
@Zlopez
Bump python version to 3.11 in pre-commit action
3e8fe25 
Signed-off-by: Michal Konecny <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/b7e02878438a49fbb4652603f44cccd0

✔️ fi-tox-mypy SUCCESS in 7m 15s
✔️ fi-tox-lint SUCCESS in 8m 10s
✔️ fi-tox-format SUCCESS in 8m 13s
✔️ fi-tox-python38 SUCCESS in 12m 19s
✔️ fi-tox-python39 SUCCESS in 12m 31s
✔️ fi-tox-python310 SUCCESS in 9m 57s
✔️ fi-tox-python311 SUCCESS in 12m 24s
✔️ fi-tox-docs SUCCESS in 7m 52s
✔️ fi-tox-bandit SUCCESS in 6m 51s
✔️ fi-tox-diff-cover SUCCESS in 13m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/2322a63db77b4be391d92af254a85f8e

✔️ fi-tox-mypy SUCCESS in 7m 38s
✔️ fi-tox-lint SUCCESS in 7m 18s
✔️ fi-tox-format SUCCESS in 7m 25s
✔️ fi-tox-python38 SUCCESS in 11m 16s
✔️ fi-tox-python39 SUCCESS in 11m 30s
✔️ fi-tox-python310 SUCCESS in 10m 27s
✔️ fi-tox-python311 SUCCESS in 11m 10s
✔️ fi-tox-docs SUCCESS in 8m 18s
✔️ fi-tox-bandit SUCCESS in 7m 20s
✔️ fi-tox-diff-cover SUCCESS in 11m 28s

@Zlopez
Copy link
Contributor Author

Zlopez commented Jan 11, 2024

I couldn't figure out why this is reporting false positives in pylint as there isn't anything directly causing this. I will keep the workflow as it's not blocking and maybe it will fix itself with some dependency upgrade.

@Zlopez Zlopez closed this Jan 11, 2024
@Zlopez Zlopez deleted the fix_precommit branch January 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zlopez