Skip to content

Support for Pylint 3 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federicobond merged 1 commit into from
Oct 31, 2023
Merged

Support for Pylint 3 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pylint_unittest/checkers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from astroid.nodes import Call, ClassDef, FunctionDef, Expr, Const, Attribute, Name

from pylint.interfaces import IAstroidChecker
from pylint.checkers.utils import check_messages
from pylint.checkers.utils import only_required_for_messages
from pylint.checkers import BaseChecker

from pylint_unittest.__pkginfo__ import BASE_ID
Expand Down Expand Up @@ -42,7 +41,6 @@ def is_self_method(node):

class UnittestAssertionsChecker(BaseChecker):
"""Unittest assertions checker."""
__implements__ = IAstroidChecker

name = 'unittest-assertions-checker'
msgs = MESSAGES
Expand All @@ -58,7 +56,7 @@ def visit_classdef(self, node):
def leave_classdef(self, node):
self._is_testcase = False

@check_messages('wrong-assert')
@only_required_for_messages('wrong-assert')
def visit_call(self, node):
if not self._is_testcase:
return
Expand Down
24 changes: 16 additions & 8 deletions tests/test_checkers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertTrue(x) or assertIs(x, True)', 'assertEqual(x, True)'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand All @@ -36,11 +37,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertFalse(x) or assertIs(x, False)', 'assertEqual(x, False)',),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand All @@ -56,11 +58,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertIsNone(x)', 'assertEqual(x, None)',),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand All @@ -76,11 +79,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertIsNone(x)', 'assertEqual(x, None)'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand All @@ -99,11 +103,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertTrue(x) or assertIs(x, True)', 'assertEqual(x, True)'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand Down Expand Up @@ -131,11 +136,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='deprecated-unittest-alias',
args=('failIfEqual', 'assertNotEqual'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand All @@ -151,11 +157,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertIsInstance(x, Class)', 'assertTrue(isinstance(x, Class))'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand Down Expand Up @@ -186,11 +193,12 @@ def test_foo():
""")

with self.assertAddsMessages(
pylint.testutils.Message(
pylint.testutils.MessageTest(
msg_id='wrong-assert',
args=('assertIsNotInstance(x, Class)', 'assertFalse(isinstance(x, Class))'),
node=assert_node,
),
ignore_position=True
):
self.checker.visit_classdef(class_node)
self.checker.visit_call(assert_node)
Expand Down