Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated finding of jobs_selector using CSS props #957

Conversation

surapuramakhil
Copy link
Contributor

@surapuramakhil surapuramakhil commented Nov 26, 2024

for selecting jobs this strategy works

selenum conidtions for this

for extracting title - we need to find anchar tag with following CSS props - font-weight: var(--artdeco-reset-typography-font-weight-bold); font-size: 1.6rem; line-height: 1.5;

for job link - link attached to same tag.

for company font-size: 1.4rem; line-height: 1.42857;
for location: font-size: 1.4rem; line-height: 1.42857;
there would be two elements first one will be company, next one will be location (this logic easily breakable, we need to filter dummy spans (robutness) )

for apply method - look for text easy apply, absences mean not easy apply job
for job state: you need search if text exist with "applied", "continue", "viewed"

@surapuramakhil surapuramakhil changed the base branch from main to hotfix/v2024.11.23 November 26, 2024 22:08
@surapuramakhil
Copy link
Contributor Author

using JS in selenium drives makes debugging tough - advice doing manipulations on python

@surapuramakhil
Copy link
Contributor Author

udate this might not. Even if it might work now but it is hard to maintain.

computed property value won't be same shown in browser inspect (always need to debug to see it's values)

@surapuramakhil
Copy link
Contributor Author

surapuramakhil commented Nov 27, 2024

udate this might not. Even if it might work now but it is hard to maintain.

computed property value won't be same shown in browser inspect (always need to debug to see) there would be lot of mess with user/CSS declared values & browser computed values.

Another problem is computed values are dependent on-screen sizes, so doesn't work for all.

@surapuramakhil
Copy link
Contributor Author

surapuramakhil commented Nov 27, 2024

Verdit - this strategy works to extent - depending on props

where it works:
you are relying on CSS props which doesn't change (from screen to screen) like - Flex, flex-direction, position

where it won't work:
sizes related - font size, font height, div height, margin, padding etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant