Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Fixed display issues #398

Closed
wants to merge 2 commits into from
Closed

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Oct 11, 2018

Issue #395
Base on #378 #384

It can support portrait mode, although it is not perfect, but it works.
In the portrait mode, the layout remains to be discussed, but I think it can help the current display.
Also fixed some display issues, when the user feels free to change the window size.

pm1
pm2
pm3

@AncalagonX
Copy link

If possible, it would be nice to make this a user-configurable setting to have it display above or below the board.

@OlivierBlanvillain
Copy link
Contributor

I'm not really a fan of this solution as is doesn't fully solves the problem: people want to customize the layout. What about using something like JToolBar? It seems like think can be moved around inside the main windows or even detached.

@zsalch
Copy link
Contributor Author

zsalch commented Oct 16, 2018

I agree that this is just a transitional solution.
The best solution is that each panel can be customized, blended or separated.
It seems that JToolBar can implement, which may be the next goal.

@zsalch zsalch changed the title next: Support portrait mode & fixed display issues next: Fixed display issues Oct 25, 2018
@OlivierBlanvillain
Copy link
Contributor

I agree that this is just a transitional solution.

Then I would be for postponing this PR until we have a definitive solution...

@zsalch
Copy link
Contributor Author

zsalch commented Oct 28, 2018

I no longer use this as a portrait mode solution, but just to solve some display issue, so I have changed the title.
Or I should close this, then wait for #402 to merge and re-open a PR that fixes the display issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants