Adding support for unnamed imports. #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvictor
reviewed
May 17, 2018
plugin/index.js
Outdated
| } | ||
| ] | ||
| }); | ||
| var content = BabelInlineImportHelper.getContents(givenPath, reference); |
There was a problem hiding this comment.
is there any reason to go for var instead of const or let?
There was a problem hiding this comment.
Great point! I have updated to use const for the variables.
richardheng-okta
force-pushed
the
unnamed-imports
branch
from
2be01b6 to
0ec1906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin will throw an error with an unnamed import:
This PR addresses the issue by transforming those expressions to string literals.