Fixing Maven Automated Publish #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainr
requested review from
rakeshkashyap123,
Yuqing-cat,
blrchen and
mufajjul
rakeshkashyap123
approved these changes
Jan 18, 2023
blrchen
approved these changes
Jan 18, 2023
4 tasks
xiaoyongzhu
added a commit
to xiaoyongzhu/feathr
that referenced
this pull request
Jan 19, 2023
This reverts commit c87c571.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where the automated maven publish was not working, the reason was the variable names used by the publish plugin is named differently.
Verified the change in my personal fork here - https://github.com/jainr/feathr/actions/runs/3945949780/jobs/6753289258
Note: The pipeline failed because there is an issue in subsequent task which I am looking at with @Yuqing-cat but maven publishing works.
How was this PR tested?
https://github.com/jainr/feathr/actions/runs/3945949780/jobs/6753289258
Does this PR introduce any user-facing changes?