Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] zsh: no matches found: feathr[notebook] during pip install feathr[notebook] #961

Merged
merged 5 commits into from
Jan 17, 2023

Conversation

ahlag
Copy link
Contributor

@ahlag ahlag commented Jan 12, 2023

Description

Resolves #960

How was this PR tested?

Change

pip install feathr[notebook]

to

pip install "feathr[notebook]"

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

xiaoyongzhu
xiaoyongzhu previously approved these changes Jan 12, 2023
@blrchen
Copy link
Collaborator

blrchen commented Jan 16, 2023

@loomlike could you please help review this PR and approve?

@xiaoyongzhu xiaoyongzhu merged commit ae752c5 into feathr-ai:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] zsh: no matches found: feathr[notebook] during pip install feathr[notebook]
3 participants