Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Bugs reported during oncall #908

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

jainr
Copy link
Collaborator

@jainr jainr commented Dec 8, 2022

Description

This PR solves two minor bugs found during bugbash/oncall

  1. TypeError: function() argument 'code' must be code, not str

from feathr import FeathrClient results in the above error.

This is caused because of package version mismatch, please run the following command to install 3.8.3 version of aiohttp package

%pip install -U aiohttp

user somehow had this version installed, which didnt work
aiohttp 3.7.4.post0

  1. Instructions to not have semi colon in SQL password

How was this PR tested?

Notebook was tested e2e successfully.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@jainr jainr changed the title Adding instructions to synapse notebook for the TypeError Fixing Bugs reported during oncall Dec 8, 2022
@xiaoyongzhu xiaoyongzhu merged commit 9a98253 into feathr-ai:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants