Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI experience and clean up ui code warnings #801

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Improve UI experience and clean up ui code warnings #801

merged 5 commits into from
Nov 1, 2022

Conversation

Fendoe
Copy link
Contributor

@Fendoe Fendoe commented Oct 31, 2022 •
edited
Loading

Description

Resolves #760 #781 #757

Fix all warining and lint issues

1667206911327

Add four common components

  • CardDescriptions
  • ProjectsSelect
  • FlowGraph
  • ResizeTable

**Update pages **

Projects Page

  • Add Searchbar. Supports fuzzy search.
  • Use ResizeTable component. Update page styles.

image

Data Sources Page

  • Use ResizeTable component. Supports table resizing.
  • Use ProjectsSelect component.

image

Features Page

  • Update SearchBar.
  • Use ResizeTable component. Supports table resizing.
  • Use ProjectsSelect component.

image

image

Lineage Page

  • Use FlowGraph. Refactor the code.
  • Remove Anchor tab.
  • Add Source node attributes.
  • Use CardDescriptions component.
  • Update Metadata tab styles.

image

Data Source Details Page

  • Update styles.
  • Use CardDescriptions component.

image

image

Features Details Page

  • Update styles.
  • Use CardDescriptions component.

image

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen changed the title Feature 760 Improve UI experience and clean up ui code warnings Nov 1, 2022
@Yuqing-cat Yuqing-cat merged commit 3025bc1 into feathr-ai:main Nov 1, 2022
loomlike pushed a commit to loomlike/feathr that referenced this pull request Nov 1, 2022
@Fendoe @loomlike
Improve UI experience and clean up ui code warnings (feathr-ai#801)
8e401b4 
* Add DataSourcesSelect and FlowGraph and ResizeTable components. Fix all warning and lint issues.

Signed-off-by: Boli Guan <[email protected]>

* Add CardDescriptions component and fix ESlint warning.

Signed-off-by: Boli Guan <[email protected]>

* Update FeatureDetails page title.

Signed-off-by: Boli Guan <[email protected]>

* Rename ProjectSelect

Signed-off-by: Boli Guan <[email protected]>

Signed-off-by: Boli Guan <[email protected]>
xiaoyongzhu pushed a commit that referenced this pull request Nov 23, 2022
@loomlike @blrchen @Fendoe
Refining example, add utilities, and fix xdist test error (#794)
15550ca 
* Fix xdist test error. Also make a small cleanup some codes

Signed-off-by: Jun Ki Min <[email protected]>

* Revert "Revert 756 (#798)"

This reverts commit ff438f5.

* revert 798 (revert756 - example notebook refactor). Also add job_utils unit tests

Signed-off-by: Jun Ki Min <[email protected]>

* Update test_azure_spark_e2e.py

* Fix doc dead links (#805)

This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed.

* Improve UI experience and clean up ui code warnings (#801)

* Add DataSourcesSelect and FlowGraph and ResizeTable components. Fix all warning and lint issues.

Signed-off-by: Boli Guan <[email protected]>

* Add CardDescriptions component and fix ESlint warning.

Signed-off-by: Boli Guan <[email protected]>

* Update FeatureDetails page title.

Signed-off-by: Boli Guan <[email protected]>

* Rename ProjectSelect

Signed-off-by: Boli Guan <[email protected]>

Signed-off-by: Boli Guan <[email protected]>

* Add release instructions for Release Candidate (#809)

* Add release instructions for Release Candidate

* Add a section for release versioning

* Add a section for overall process triggered by the release manager

* Bump version to 0.9.0-rc1 (#810)

* Fix tests to use mocks and fix get_result_df's databricks behavior

Signed-off-by: Jun Ki Min <[email protected]>

* fix tem file to dir

Signed-off-by: Jun Ki Min <[email protected]>

* checkout the feature_derivations.py from main (it was temporally changed to goaround previous issues)

Signed-off-by: Jun Ki Min <[email protected]>

* Remove old databricks sample notebook. Change pip install feathr from the github main branch to pickup the latest changes always

Signed-off-by: Jun Ki Min <[email protected]>

* Fix config and get_result_df for synapse

* Fix generate_config to accept all the feathr env var config name

Signed-off-by: Jun Ki Min <[email protected]>

* Add more pytests

Signed-off-by: Jun Ki Min <[email protected]>

* Use None as default dataformat in the job_utils. Instead, set 'avro' as a default output format to the job tags from the client

Signed-off-by: Jun Ki Min <[email protected]>

* Change feathr client to mocked object

Signed-off-by: Jun Ki Min <[email protected]>

* Change timeout to 1000s in the notebook

Signed-off-by: Jun Ki Min <[email protected]>

Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: Boli Guan <[email protected]>
Co-authored-by: Blair Chen <[email protected]>
Co-authored-by: Blair Chen <[email protected]>
Co-authored-by: Boli Guan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Yuqing-cat Yuqing-cat Yuqing-cat approved these changes

@blrchen blrchen blrchen approved these changes

@donegjookim donegjookim Awaiting requested review from donegjookim donegjookim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Fix all warning and lint issues
3 participants
@Fendoe @blrchen @Yuqing-cat