Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a custom pytest marker config to pyproject.toml #786

Merged
merged 21 commits into from
Nov 22, 2022
Merged

Add a custom pytest marker config to pyproject.toml #786

merged 21 commits into from
Nov 22, 2022

Conversation

loomlike
Copy link
Collaborator

Description

This PR is to add pytest's custom marker config to pyproject. This will resolve related warnings.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@loomlike
Fix local spark output file-format bug
b4f09d7 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Add dev dependencies. Add unit-test for local spark job launcher
283b7c8 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Fix local spark submission unused param error
d6c24bf 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/localspark_submission_fix
24aaaea
@loomlike
Refactor nyc_taxi example. TODO: update refs to the notebook
bb76c43 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Add dataset utilities and notebook path refactor. TODO: update refere…
8447f31 
…nce links

Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Add init.py to datasets module. Modify maybe_download to accept dir a…
ad4942c 
…s dst_path

Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/example_notebook
d16d1e1
@loomlike
Add notebook test
b72ff3b 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
change notebook to use scrap flag and is_databricks
9ed4b96 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Fix databricks path
656d50d 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Fix unittest
06008ee 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Modify databricks notebook. Fix dbfs path errors in utils.
2a36d51 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/example_notebook
9db09df
@loomlike
Address review comments
4c020dc 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
put the user_workspace feature python files back
3ecc70a 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/example_notebook
db25051
@loomlike
Revive feathr_config.yaml
bd9fdb3 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/example_notebook
fe40c47
@loomlike
Add custom marker to pyproject.toml
f22f114 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Merge branch 'main' into jumin/example_notebook
eeb8b0a
@blrchen blrchen added the safe to test Tag to execute build pipeline for a PR from forked repo label Oct 28, 2022
@loomlike loomlike mentioned this pull request Nov 1, 2022
Merged
2 tasks
@xiaoyongzhu xiaoyongzhu merged commit ca09fe3 into feathr-ai:main Nov 22, 2022
@loomlike loomlike deleted the jumin/example_notebook branch December 20, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@edwincheung edwincheung Awaiting requested review from edwincheung

@enya-yx enya-yx Awaiting requested review from enya-yx

@hangfei hangfei Awaiting requested review from hangfei

@jainr jainr Awaiting requested review from jainr

@mufajjul mufajjul Awaiting requested review from mufajjul

@windoze windoze Awaiting requested review from windoze

@Yuqing-cat Yuqing-cat Awaiting requested review from Yuqing-cat

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loomlike @xiaoyongzhu @blrchen