Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite feature registry with new Pythonic APIs and add tagging support #105

Merged
merged 32 commits into from
Apr 12, 2022

Conversation

xiaoyongzhu
Copy link
Member

@xiaoyongzhu xiaoyongzhu commented Mar 31, 2022

This PR focus on the following goals with minimal end user facing impact:

  1. shift the implementation from HOCON based parsing to python API parsing, which is more stable and more scalable.
  2. Fix the hierarchy issue. Previously source is on project level. with this fix, source should be on anchor level.
  3. Derived feature support. Now the input features for derived features can be parsed.
  4. Supporting adding tags for all the Feathr entities, including project, anchor, anchor feature, derived feature, source, to allow customization.
  5. helper functions to facilitate testing & migration
  6. feathr entity search support ,which facilitate future development work
  7. Remove undocumented functionalities that needs further discussion (client.get_features)

image

image

feathr_project/feathr/anchor.py Outdated Show resolved Hide resolved
feathr_project/feathr/client.py Outdated Show resolved Hide resolved
feathr_project/feathr/client.py Outdated Show resolved Hide resolved
feathr_project/feathr/client.py Outdated Show resolved Hide resolved
feathr_project/feathr/constants.py Outdated Show resolved Hide resolved
feathr_project/feathr/constants.py Outdated Show resolved Hide resolved
feathr_project/test/test_feature_registry.py Outdated Show resolved Hide resolved
feathr_project/test/test_fixture.py Outdated Show resolved Hide resolved
feathr_project/test/test_feature_registry.py Outdated Show resolved Hide resolved
feathr_project/setup.py Show resolved Hide resolved
feathr_project/feathr/anchor.py Outdated Show resolved Hide resolved
feathr_project/feathr/feature_derivations.py Outdated Show resolved Hide resolved
feathr_project/feathr/constants.py Show resolved Hide resolved
hangfei
hangfei previously approved these changes Apr 12, 2022
@xiaoyongzhu xiaoyongzhu merged commit f1183c6 into main Apr 12, 2022
@xiaoyongzhu xiaoyongzhu deleted the registry_fix branch August 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants