Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating various sections of documentation based on customer feedback. #1016

Merged
merged 11 commits into from
Jan 30, 2023
Merged

Updating various sections of documentation based on customer feedback. #1016

merged 11 commits into from
Jan 30, 2023

Conversation

jainr
Copy link
Collaborator

@jainr jainr commented Jan 28, 2023

Description

  • Added Note for CLI documentation and the risks there.
  • Added note for all optional steps
  • Added documentation for storing secrets in KV.
  • Added clean up section with command in the documentation

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu xiaoyongzhu merged commit 9b23821 into feathr-ai:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuqing-cat Yuqing-cat Yuqing-cat approved these changes

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@blrchen blrchen Awaiting requested review from blrchen

@edwincheung edwincheung Awaiting requested review from edwincheung

@mufajjul mufajjul Awaiting requested review from mufajjul

@windoze windoze Awaiting requested review from windoze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jainr @xiaoyongzhu @Yuqing-cat