Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addItems calls new Model calls addItem #492

Merged
merged 1 commit into from
Jun 21, 2020
Merged

fix: addItems calls new Model calls addItem #492

merged 1 commit into from
Jun 21, 2020

Conversation

fratzinger
Copy link
Collaborator

There's a loop between mutations & Model for creating models.
When you call addItems for completely new data, it calls new Model which commits addItem which calls new Model which commits mergeInstance

@fratzinger
fix: addItems calls new Model calls addItem
de3c11e 
There's a loop between mutations & Model for creating models
When you call addItems for completely new data, it calls `new Model` which commits `addItem` which calls `new Model` which commits `mergeInstance`
@marshallswain
Copy link
Member

Ah thanks!

@marshallswain marshallswain merged commit e0b108a into feathersjs-ecosystem:master Jun 21, 2020
@fratzinger fratzinger deleted the patch-10 branch August 23, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fratzinger @marshallswain