Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allow passing auth params #474

Merged
merged 3 commits into from
May 2, 2020
Merged

feature: allow passing auth params #474

merged 3 commits into from
May 2, 2020

Conversation

hamiltoes
Copy link
Contributor

Summary

Allow passing params to feathers.authenticate() via auth module authenticate action.

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
    • no
  • Is this PR dependent on PRs in other repos?
    • no

Other Information

Should this be mentioned in the docs?

J3m5
J3m5 suggested changes May 1, 2020
View reviewed changes
Copy link
Contributor

@J3m5 J3m5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: This can be refactored in a more succinct way like this:

const [data, params] = Array.isArray(dataOrArray) ? dataOrArray : [dataOrArray]

Thank you for this PR!

@marshallswain
Copy link
Member

Love to see the tests, too! Thank you so much!

@marshallswain marshallswain merged commit 3ce8647 into feathersjs-ecosystem:master May 2, 2020
@hamiltoes hamiltoes deleted the feature/auth-params branch May 2, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J3m5 J3m5 J3m5 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamiltoes @marshallswain @J3m5