Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #466 (Bug: FeathersVuexFind component) #467

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix issue #466 (Bug: FeathersVuexFind component) #467

merged 1 commit into from
Apr 28, 2020

Conversation

Barbapapazes
Copy link
Contributor

@Barbapapazes Barbapapazes commented Apr 26, 2020

Summary

issue #466

Bug in the component FeathersVuexFind

There was a problem with the watch property who was watching query, even a fetchQuery was provided. This was due to the method replace() which return a new string, and not change the string (mdn js doc).

It's fix. Thank you !

@Barbapapazes Barbapapazes changed the title fix issue #466 (Bug: FeathersVuexFind components) fix issue #466 (Bug: FeathersVuexFind component) Apr 26, 2020
@J3m5 J3m5 mentioned this pull request Apr 26, 2020
@marshallswain
Copy link
Member

Ah good catch! Thanks!

@marshallswain marshallswain merged commit 0d50b62 into feathersjs-ecosystem:master Apr 28, 2020
@marshallswain
Copy link
Member

Released on npm as [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants