This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Socket.io 1.4.0 broke feathers #10
Comments
Someone created an issue in socket.io already. socketio/socket.io#2368 |
Sounds good. What does the object look like? Can we map it back to an array if necessary? |
It's just empty. We can map it or just fix our versioning to be |
Will need to be updated for the 2.0 release but I'd like to see what happens in the socket.io first. This just happened a few hours ago. |
This should be good all releases now. Even the Feathers 2.0 release, regardless of whether they revert that change in the socket.io lib. |
daffl
added a commit
that referenced
this issue
Jan 6, 2016
daffl
added a commit
that referenced
this issue
Jan 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The call to
info.clients()
now returns an object. Bad versioning 😢See: https://github.com/feathersjs/feathers-commons/blob/master/src/sockets/helpers.js#L37
The text was updated successfully, but these errors were encountered: