Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Socket.io 1.4.0 broke feathers #10

Closed
ekryski opened this issue Jan 6, 2016 · 5 comments
Closed

Socket.io 1.4.0 broke feathers #10

ekryski opened this issue Jan 6, 2016 · 5 comments

Comments

@ekryski
Copy link
Member

ekryski commented Jan 6, 2016

The call to info.clients() now returns an object. Bad versioning 😢

See: https://github.com/feathersjs/feathers-commons/blob/master/src/sockets/helpers.js#L37

@ekryski
Copy link
Member Author

ekryski commented Jan 6, 2016

Someone created an issue in socket.io already. socketio/socket.io#2368

@daffl
Copy link
Member

daffl commented Jan 6, 2016

Sounds good. What does the object look like? Can we map it back to an array if necessary?

@ekryski
Copy link
Member Author

ekryski commented Jan 6, 2016

It's just empty. We can map it or just fix our versioning to be 1.3.x in this repo.

@ekryski
Copy link
Member Author

ekryski commented Jan 6, 2016

Will need to be updated for the 2.0 release but I'd like to see what happens in the socket.io first. This just happened a few hours ago.

@ekryski ekryski closed this as completed in 858a264 Jan 6, 2016
@ekryski
Copy link
Member Author

ekryski commented Jan 6, 2016

This should be good all releases now. Even the Feathers 2.0 release, regardless of whether they revert that change in the socket.io lib.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants