This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Changed code to accommodate MongoDB's ObjectID #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert-args-to-feathers now uses lodash.mergewith instead of deepmerge, as mergewith retains 'instance of ObjectID' for ObjectID objects. - lodash.merge may have been sufficient as the customizer for mergewith is no-op'ed. It however has code to explicitly reconstruct an ObjectID object. This may be needed based on test results, and it can be expanded for other similar situations. - convert-args-to-parms converts prop names starting with __ to ones starting with $, e.g. __sort to $sort. The previous code lost 'instance of ObjectID' for ObjectID objects. The new code does not, though it takes longer to execute.
- GraphQL's args param to resolves does not inherit from Object and neither do inner objects. Neither do nested objects within args. - lodash.mergewith faithly copies objects from args so they don't inherit from Object. - NeDB is one database which requires its args to inherit from Object. Some parts of Feathers do likelwise. - This commit converts args abd nested objects to inherit from Object.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mergewith retains 'instance of ObjectID' for ObjectID objects.
is no-op'ed. It however has code to explicitly reconstruct an ObjectID
object. This may be needed based on test results, and it can be
expanded for other similar situations.
with $, e.g. __sort to $sort. The previous code lost 'instance of ObjectID'
for ObjectID objects. The new code does not, though it takes longer to execute.