Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Remove dataloader ref & remove debugging .catch() in service #1

Merged
merged 1 commit into from
Jan 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@
- deps: fields to also fetch when a field is specified. useful for calculated fields

- Dataloaders
- serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys
NO - serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys
NO --> Let user handle this as we think object keys will be rarely used.

- services
- metadata to allow paths such as `a-b/c`.
- allow paths that are not valid JS names

- join-monster
- seems to have a bug. see test for findUsers.
- seems to have a bug. see test for findUsers. Something returns null instead of [].

- Register pluggable middleware functions, like in Express, to run before and after GraphQL resolvers. Auth, permissions, filters, etc.
- https://github.com/alekbarszczewski/graphql-add-middleware
Expand Down
9 changes: 0 additions & 9 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,6 @@ class Service {
errors,
data: response.data // Return what GraphQL data is available. Likely contains 'null's.
});
})
// todo Remove. *****************************************************
.catch(err => {
/* eslint-disable */
console.log('\n========== graphql adapter error catch');
console.log(err);
console.log('==========\n');
/* eslint-enable */
throw err;
});
}
}
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"@feathers-plus/cache": "1.3.1",
"@feathers-plus/common": "0.1.0",
"@feathersjs/errors": "3.2.0",
"dataloader-align-results": "0.4.0",
"debug": "3.1.0",
"deepmerge": "1.5.2",
"feathers-hooks-common": "3.7.3",
Expand Down