Merge pull request #1 from feathers-plus/batchloader-01

Remove dataloader ref & remove debugging .catch() in service
feathers-plus · Jan 29, 2018 · ee7491d · ee7491d
2 parents 572d797 + 2efd7a3
commit ee7491d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/TODO.md b/TODO.md
@@ -4,14 +4,15 @@
     - deps: fields to also fetch when a field is specified. useful for calculated fields
 
 - Dataloaders
-    - serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys
+    NO - serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys
+    NO   --> Let user handle this as we think object keys will be rarely used.
 
 - services
     - metadata to allow paths such as `a-b/c`.
     - allow paths that are not valid JS names
 
 - join-monster
-    - seems to have a bug. see test for findUsers.
+    - seems to have a bug. see test for findUsers. Something returns null instead of [].
 
 - Register pluggable middleware functions, like in Express, to run before and after GraphQL resolvers. Auth, permissions, filters, etc.
     - https://github.com/alekbarszczewski/graphql-add-middleware

diff --git a/lib/index.js b/lib/index.js
@@ -82,15 +82,6 @@ class Service {
           errors,
           data: response.data // Return what GraphQL data is available. Likely contains 'null's.
         });
-      })
-      // todo Remove. *****************************************************
-      .catch(err => {
-        /* eslint-disable */
-        console.log('\n========== graphql adapter error catch');
-        console.log(err);
-        console.log('==========\n');
-        /* eslint-enable */
-        throw err;
       });
   }
 }

diff --git a/package.json b/package.json
@@ -52,7 +52,6 @@
     "@feathers-plus/cache": "1.3.1",
     "@feathers-plus/common": "0.1.0",
     "@feathersjs/errors": "3.2.0",
-    "dataloader-align-results": "0.4.0",
     "debug": "3.1.0",
     "deepmerge": "1.5.2",
     "feathers-hooks-common": "3.7.3",