-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add divide
icons
#568
Conversation
Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment plus, minus, and x icons.
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
Branches 3 3
=========================================
Hits 34 34 Continue to review full report at Codecov.
|
@csandman These look great! Thanks for opening a PR 🎉 My only feedback is that the dots on the Could you try a version that uses a larger circle similar to the |
@colebemis Sorry I saw your comment so late! I gave it a shot, is this what you were thinking of?
The main reason I avoided this is because I felt that the circles were a bit too large but its up to you. |
@csandman If you zoom out the divide icon looks perfect with bigger dots. |
Update branch with master
I know this is rather old, but I never pushed my change with the change requested by @colebemis Anyway, now I have so feel free to merge if you like the change! Here is what all 3 icons look like in context of the other icons: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @csandman! ❤️
Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment the plus, minus, and x icons and fill out the set of math icons.
The shapes are composed the same way as they are in the other math icons, using 1px lines for the points.
Closes #263