feat: Feast/IKV online store contrib plugin integration #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarmoi
changed the title
Signed-off-by: Pushkar Gupta <[email protected]>
Signed-off-by: Pushkar Gupta <[email protected]>
Signed-off-by: Pushkar Gupta <[email protected]>
auto-merge was automatically disabled
April 3, 2024 01:14
Head branch was pushed to by a user without write access
Signed-off-by: Pushkar Gupta <[email protected]>
tokoko
reviewed
Apr 3, 2024
setup.py
Outdated
| @@ -209,6 +213,7 @@ | |||
| + CASSANDRA_REQUIRED | |||
| + AZURE_REQUIRED | |||
| + ROCKSET_REQUIRED | |||
| + IKV_REQUIRED | |||
There was a problem hiding this comment.
This is not necessary, since we are not adding tests to run on ci at this point
There was a problem hiding this comment.
thanks for flagging, removed
Signed-off-by: Pushkar Gupta <[email protected]>
Signed-off-by: Pushkar Gupta <[email protected]>
Signed-off-by: Pushkar Gupta <[email protected]>
Signed-off-by: Pushkar Gupta <[email protected]>
|
Closed this and opened #4068 to work-around DCO issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We add a new online store (IKV - https://www.inlined.io/) to feast by following the guide here:
docs.feast.dev/how-to-guides/customizing-feast/adding-support-for-a-new-online-store