Skip to content
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.

fix: Handle resize event in crossterm demo #252

Closed
wants to merge 1 commit into from

Conversation

heyrict
Copy link

@heyrict heyrict commented Mar 25, 2020

This PR pipes crossterm::Event::Resize to the ui, forcing the ui to re-render after resize.

Fixes #250.

@extrawurst
Copy link
Contributor

Hi @heyrict thanks for following up on #250 but I checked this out on my machine and it does not fix the issue. it turns out that when I checkout your fork it works because for some reason it compiles against Crossterm 0.10 while my local repo uses 0.16 - please try your change against recent Crossterm and I think u will see the issue aswell.

The main issue that this shows is: the Cargo.lock file is on .gitignore which allows everyone to build against different sets of versions. Is there any reason for this @fdehau ?

@heyrict heyrict closed this Mar 25, 2020
@heyrict heyrict deleted the fix-250 branch March 25, 2020 10:36
@fdehau
Copy link
Owner

fdehau commented Mar 31, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crossterm (re)size broken
3 participants