This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
add clear widget and popup example utilizing it #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
force-pushed
the
popup_clear_widget
branch
from
2996e9c
to
6ee1b0e
Compare
|
The example may be a bit complicated for this feature but otherwise this looks good. |
|
ok! how much time do I have to add documentation to be able to get it in for 0.9? |
|
I'm waiting for a stable release of crossterm (i.e with bug fixes for the recent reported issues). I think you'll have a fair amount of time and this could go in a 0.9.1 if not. |
extrawurst
force-pushed
the
popup_clear_widget
branch
2 times, most recently
from
09a5e90
to
3acdca1
Compare
extrawurst
force-pushed
the
popup_clear_widget
branch
from
92e68a0
to
f971178
Compare
extrawurst
changed the title
|
@fdehau docs with doc example added, ready to pull PS: the crossterm fixes have also landed 👍 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #244 and #211
Please give me a first review before I go about documentation.