[DRAFT] Add additional statistics and histogram visualization #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddeoa
changed the title
|
Added the DRAFT prefix to get some feedback on the unwrapping. I don't write rust enough to know exactly what's safe/best practices there. |
I was hitting panics when tests would add values that were out of range of the histogram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few statistics so the report, as well as a visualization of the global histogram, which I find very useful with another tool
hey.I improvised the color scheme to match the existing one (yellow/purple).
I kept it out of the individual smaller reports for fear of making the output too verbose.