Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Atomic Batch Operations into its own specification. #1

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

ruebot
Copy link
Contributor

@ruebot ruebot commented Mar 23, 2017

@ruebot
Copy link
Contributor Author

ruebot commented Mar 23, 2017

@awoods I think you'll need to turn TravisCI on for this repo.

@zimeon
Copy link
Contributor

zimeon commented Mar 23, 2017

👍 good to get this out without much fuss to have something to work against

@acoburn
Copy link
Contributor

acoburn commented Mar 23, 2017

@ruebot I just enabled on travis builds for this repo

@ruebot
Copy link
Contributor Author

ruebot commented Mar 23, 2017

@acoburn cool. I can push another commit if y'all want a Travis run.

@@ -0,0 +1,9 @@
language: java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would python be more appropriate here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can crib from this if you want to use Python -- either way you'll need Java.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the same exact TravisCI config from the API spec repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on leaving this as it is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is Travis doing for us here beyond running html5validator and why is Java the appropriate language setting for running that python script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the python script wraps a Java library. So you need both Python and Java in order to run html5validator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awoods I would add that I have no particular commitment to using html5validator, but it catches a lot of simple HTML errors and seems to work well. If there is another tool that is better, that's fine, but html5validator certainly does the job.

Copy link
Contributor

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awoods awoods merged commit 4397724 into fcrepo:master Mar 24, 2017
@ruebot ruebot deleted the start branch March 24, 2017 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove batch operations from the specification
4 participants