data connection stealing and bounce attack mitigation #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 84.70% 85.61% +0.90%
==========================================
Files 10 10
Lines 1471 1522 +51
==========================================
+ Hits 1246 1303 +57
+ Misses 151 146 -5
+ Partials 74 73 -1
Continue to review full report at Codecov.
|
If we allow a trusted network when using HAProxy we don't have any security. All the passive connections will come through the proxy and so they will be allowed. We have to require to add the proxy header for both control and passive data connection. The new optional interface allows to wrap the passive listener and so decode the proxy header and get the real client IP
|
Sorry for the delay @drakkan and thank you for this improvement (which required a lot of testing effort 😅 👍), it's indeed a good way to mitigate FTP security issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improve security for passive connections and fixes bounce attacks for active ones.
IPMatchRelaxedandIPMatchTrustedare useful for passive connections if using haproxy. We can get rid of these settings if we expose a callback for the passive connection listener, so we can provide a custom listener that decodes the proxy header and get the real client IP as we do for the control connection. ProFTPD does not recommend to enable the proxy header for data connections and I followed the same recommendation for SFTPGo until now, no problem to change if you prefer this way.See the FAQ here