Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't quit listener after a temporary accept error #211

Merged
merged 3 commits into from
Dec 24, 2020

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Dec 23, 2020

Fixes #210

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #211 (6362b7e) into master (6026640) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   78.90%   79.29%   +0.38%     
==========================================
  Files           9        9              
  Lines        1209     1222      +13     
==========================================
+ Hits          954      969      +15     
+ Misses        171      169       -2     
  Partials       84       84              
Impacted Files Coverage Δ
server.go 65.82% <100.00%> (+9.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6026640...6362b7e. Read the comment docs.

@probot-auto-merge probot-auto-merge bot merged commit 87b8b93 into fclairamb:master Dec 24, 2020
@drakkan drakkan deleted the accept-err branch February 3, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not quit serve loop on temporary accept errors?
2 participants