Fixing #162

[fclairamb]

The file transfer logic was a bit broken and could end-up performing two replies to a STOR command.

This now correctly reports:

• errors during file transfer & write (was already supported)
• errors during file close and transfer connection close (which is reported as an error)

Please note that this issue probably wasn't introduced by #161, it might have always existed.

[codecov]

Codecov Report

Merging #202 (1a87dae) into master (c84759b) will increase coverage by 1.55%.
The diff coverage is 80.59%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   71.07%   72.62%   +1.55%     
==========================================
  Files           9        9              
  Lines         999     1001       +2     
==========================================
+ Hits          710      727      +17     
+ Misses        207      194      -13     
+ Partials       82       80       -2     

Impacted Files	Coverage Δ
client_handler.go	62.23% <73.33%> (+2.01%)	⬆️
handle_files.go	77.05% <82.69%> (+4.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84759b...1a87dae. Read the comment docs.

[drakkan]

Hi,

I had a similar fix locally, the two replies to STOR were triggered as soon as I moved the transfer to a separate goroutine (to support ABOR). I merged my changes with yours, please take a look and thank you!

[fclairamb]

Perfect !