Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a comparison of the reportname with OS / Role followed by a question #336

Closed
svndh opened this issue Jul 7, 2023 · 2 comments · Fixed by #418
Closed

Include a comparison of the reportname with OS / Role followed by a question #336

svndh opened this issue Jul 7, 2023 · 2 comments · Fixed by #418
Assignees
Labels
enhancement New feature or request minor Incremental updates and enhancements for improved functionality without major changes.
Milestone

Comments

@svndh
Copy link

svndh commented Jul 7, 2023

Issue:

The User chooses for example to create an AuditTAP report based on the Reportname Microsoft Windows Server 2019.

From now on, all of the following scenarios are possible:

  1. The User does know that the underlying OS is Microsoft Windows Server 2019 and therefore he chose the right reportname.
  2. The User thinks that the underlying OS is Microsoft Windows Server 2019 but actually it is Microsoft Windows Server 2016 and he still chose the Reportname Microsoft Windows Server 2019. --> User has made a mistake and the results are affected
  3. The User does know that the underlying OS is Microsoft Windows Server 2016 and for some purpose the user still chose the reportname of another role --> User made a conscious choice

Solution

  1. Perform a comparison of the report name with the operating system / role from which the report creation is started.
  2. If reportname and OS/Role differ, generate a prompt for the user with a short description
  3. Also include a comparison of role differences (for example OS is Microsoft Windows Server 2019 with installed DC Role but user only chooses Microsoft Windows Server 2019 and vice versa)
  4. If reportname and OS/Role do not differ, everything works as usual

Question could be implemented like the both following examples:

Example only with OS

Reportname Validation
You chose the Reportname _Microsoft Windows Server 2019 but the operating system is _Microsoft Windows Server 2016.
Be aware that a different report type could affect the result. Do you really want to continue?
[Y] Yes [N] No

Example with OS and Role

Reportname Validation
You chose the Reportname _Microsoft Windows Server 2019 but the operating system is _Microsoft Windows Server 2019 acting as a Domain Controller.
Be aware that a different report type could affect the result. Do you really want to continue?
[Y] Yes [N] No

@TuemmlerKelch TuemmlerKelch added the enhancement New feature or request label Jul 19, 2023
@TuemmlerKelch TuemmlerKelch added this to the 6.0 milestone Jul 19, 2023
@TuemmlerKelch TuemmlerKelch added the minor Incremental updates and enhancements for improved functionality without major changes. label Jul 19, 2023
@TuemmlerKelch
Copy link
Collaborator

Great idea. I suggest implementing it like this:
We concentrate only on OS and type (standalone or domain member). Should desired report not match actual report, we present the user with the following:

Selected report ($reportname) and actual OS ($actualOS) do not match. Please select one of the following options:
1 - Create report for ($actualOS)
2 - Continue with your selection ($reportname)
3 - Show available reports

@TuemmlerKelch
Copy link
Collaborator

Not implemented for Linux, but fine for Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Incremental updates and enhancements for improved functionality without major changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants