Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies and many more fun! #9

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Upgrade dependencies and many more fun! #9

wants to merge 14 commits into from

Conversation

aitorjs
Copy link

@aitorjs aitorjs commented Apr 30, 2017

Improvements made:

  • Dependencies upgrated: @angular/cli 1.0.1, angular2-schema-form 1.0.0-alpha.33 and the lastest versions.
  • Model added to component template.
  • New way to charge schema and model using JavaScript classes and methods.
  • Added Twitter bootsrap from npm and .angular-cli

Aitor Ibañez added 14 commits April 28, 2017 13:25
- Demo using @angular/cli >= 1.0.0 and using the last version
79fb190 
of angular2-schema-form (1.0.0-beta.7)
- Added new files
c79e393
- Added required styles and templates.
d8f9000 
- Charging this.model directly.
- Missig requireds added.
d5cbb21 
- Main tag changed from app-root to sf-demo-app.
- index.html updated.
bc449ed
- README.md updated.
80722dc
- JSONs required. samplemodel.json from http. sampleschema.json, for now
6a71cd8 
imposible.
- Model added to form.
8738851
- Added new away to charge schema and model using classes and methods.
1cc4bda
- Improved config.ts
4cf980d
- Added Twitter bootsrap from npm and .angular-cli
5dadc38
- app.css added to .angular-cli.json.
fcea13f 
- Http module deleted from demo.
- README updated.
ae8e02b
- Config added from class constants.
8f6e34b
fbessou
fbessou requested changes May 4, 2017
View reviewed changes
Copy link
Owner

@fbessou fbessou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for these contribution ! 😀
That was a lot of reading :)
Before I merge could you

  • remove/revert the commit ae8e02b
    as it is not related to this repository
  • remove end-to-end tests as they are not testing anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbessou fbessou fbessou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitorjs @fbessou