Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runtime build watch, remove custom condition, update TS templates #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3-alpha-feature/event-types
Are you sure you want to change the base?
Add runtime build watch, remove custom condition, update TS templates #11
Changes from 9 commits
1a72b73
04ddcd1
44b3764
f2cb563
2777367
9805906
b2111dc
4302868
3c77d11
af41cd0
b0d3049
44b6a88
03965c0
268f485
503d2f5
eab8feb
77b2891
c69da05
cd28108
0222d94
940b6b1
50bd660
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was throwing an error in the
lit-ts
project without this. I'm not sure why it didn't error in the runtime project too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A stricter
Promise<void>[]
should be fine as well. Still good thoughThis file was deleted.
This file was deleted.
This file was deleted.