-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vite-plugin, jsconfig, dev-mode runtime to JS templates #10
Add vite-plugin, jsconfig, dev-mode runtime to JS templates #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IanVS The JS react template has a tsconfig instead of a jsconfig. Just wanted to make sure this is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right it should be jsconfig, good catch.
This gets all the non-typescript templates into good shape.
jsconfig.json
to them all, customized slightly for svelte, sveltekit, and vue to respect their special filetypes.vite-env.d.ts
files to the js templates (for autocompletion support)Also:
package-lock.json
from the sveltekit templates. New projects should create their own package-lock files, not use an old one from the templatesveltekit
template.