Allow escaped parentheses in pseudo selectors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
reviewed
Feb 22, 2018
index.js
Outdated
| var slashCount = 0; | ||
|
|
||
| while (selector.charAt(--pos) === '\\') slashCount++; | ||
| return !!(slashCount&1); |
There was a problem hiding this comment.
return slashCount & 1 === 0;is a bit more explicit and should be easier to read.
fb55
reviewed
Feb 22, 2018
index.js
Outdated
| } | ||
|
|
||
| function checkEscaped(pos) { | ||
| var slashCount = 0; |
There was a problem hiding this comment.
Move checkEscaped to the outer scope
|
Tests are failing & two nits, otherwise lgtm :) |
DShadrick
force-pushed
the
master
branch
2 times, most recently
from
c4db942
to
de002d1
Compare
|
Made the requested updates and fixed the testing errors. |
|
Nice, thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for the inclusion of escaped parenthesis inside of a sudo selector. Updated previous change to iterate backwards to also allow for the inclusion of escaped escape characters.