Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ack for tombstones in cython-stream #39

Merged

Conversation

trauter
Copy link
Contributor

@trauter trauter commented Nov 18, 2020

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Previously, Tombstones have neither been forwarded to the processor nor ack'ed.
copy of robinhood/faust#547

NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.

If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #39 (607be47) into master (18230a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   63.94%   63.94%           
=======================================
  Files          99       99           
  Lines       10274    10274           
  Branches     1154     1154           
=======================================
  Hits         6570     6570           
  Misses       3549     3549           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18230a7...607be47. Read the comment docs.

@patkivikram patkivikram merged commit 41d3e6b into faust-streaming:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants