Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recovery of partitions for large volume writes #335

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Fix recovery of partitions for large volume writes #335

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
781947f
commit inital fix for #333
wbarnha Aug 8, 2022
7047a4b
manually lint comment
wbarnha Aug 8, 2022
de163f7
Merge branch 'master' into recovery-patch
wbarnha Aug 8, 2022
d31239b
allow multiple partitions to resume
wbarnha Aug 9, 2022
a95950a
minor cleanup
wbarnha Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions faust/tables/recovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,16 @@ async def _restart_recovery(self) -> None:
# The changelog partitions only in the active_tps set need to be resumed
active_only_partitions = active_tps - standby_tps
if active_only_partitions:
T(consumer.resume_partitions)(active_only_partitions)
T(self.app.flow_control.resume)()
T(consumer.resume_flow)()
# Support for the specific scenario where recovery_buffer=1
tps_resuming = [
tp
for tp in active_only_partitions
if self.tp_to_table[tp].recovery_buffer_size == 1
]
if tps_resuming:
T(consumer.resume_partitions)(tps_resuming)
T(self.app.flow_control.resume)()
T(consumer.resume_flow)()

self.log.info("Recovery complete")
if span:
Expand Down