Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a few small mistakes in streams userguide #161

Merged
merged 1 commit into from
Jun 17, 2021
Merged

fixed a few small mistakes in streams userguide #161

merged 1 commit into from
Jun 17, 2021

Conversation

peonone
Copy link
Contributor

@peonone peonone commented Jun 15, 2021

Fixed a few small mistakes in streams user guide doc:

  1. The code block to acknowledge an event manually is not highlighted
  2. The indent is not the same (4 spaces) for some code blocks
  3. The keyword to acknowledge an event automatically should be async with

@patkivikram patkivikram merged commit c45a464 into faust-streaming:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patkivikram patkivikram patkivikram approved these changes

@taybin taybin taybin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peonone @taybin @patkivikram