Skip to content

Fix pep517 builds#23

Merged
wbarnha merged 17 commits into
faust-streaming:masterfrom
bdraco:pep517_builds
Feb 21, 2023
Merged

Fix pep517 builds#23
wbarnha merged 17 commits into
faust-streaming:masterfrom
bdraco:pep517_builds

Conversation

@bdraco
Copy link
Copy Markdown

@bdraco bdraco commented Feb 20, 2023

python3 -m pep517.check . now passes

Test run https://github.com/bdraco/cChardet/actions/runs/4219774165

The extension has returned to having the modified uchardet directly linked in.

This is currently blocking Home Assistant from using this library with python 3.11 until we can get a new release with working pep517 builds.

https://github.com/home-assistant/core/actions/runs/4217296920/jobs/7320979916

Thanks for looking at this PR!

`python3 -m pep517.check` now passes
@wbarnha
Copy link
Copy Markdown
Member

wbarnha commented Feb 20, 2023

Thanks for the PR! I don't get as much time to troubleshoot issues as I'd like.

@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 20, 2023

Still working this out but will mark it ready when I get it in a good state.

https://github.com/bdraco/cChardet/actions/runs/4219137888/jobs/7324220109

@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 20, 2023

Still failing on 32bit only.

@bdraco bdraco marked this pull request as ready for review February 20, 2023 03:44
@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 20, 2023

Test build just about done here https://github.com/bdraco/cChardet/actions/runs/4219774165 and should pass.

@wbarnha
Copy link
Copy Markdown
Member

wbarnha commented Feb 21, 2023

Excellent, thanks for your hard work! I'll get this merged momentarily.

@wbarnha wbarnha merged commit f2efad3 into faust-streaming:master Feb 21, 2023
@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 21, 2023

@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 21, 2023

@bdraco
Copy link
Copy Markdown
Author

bdraco commented Feb 21, 2023

ahh its disabled on forks

@wbarnha
Copy link
Copy Markdown
Member

wbarnha commented Feb 21, 2023

Yeah... oops. I'm thinking we just disable source distro anyways since we support almost every platform except ARM macOS.

@wbarnha
Copy link
Copy Markdown
Member

wbarnha commented Feb 21, 2023

It's unfortunate that the Linux builds take one hour to build and test since we're testing for so many different platforms. I should probably add some logic to just test x86-64 Linux for non-releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants