Fix pep517 builds#23
Conversation
`python3 -m pep517.check` now passes
|
Thanks for the PR! I don't get as much time to troubleshoot issues as I'd like. |
|
Still working this out but will mark it ready when I get it in a good state. https://github.com/bdraco/cChardet/actions/runs/4219137888/jobs/7324220109 |
|
Still failing on 32bit only. |
|
Test build just about done here https://github.com/bdraco/cChardet/actions/runs/4219774165 and should pass. |
|
Excellent, thanks for your hard work! I'll get this merged momentarily. |
|
Looks like the source distro build failed |
|
ahh its disabled on forks |
|
Yeah... oops. I'm thinking we just disable source distro anyways since we support almost every platform except ARM macOS. |
|
It's unfortunate that the Linux builds take one hour to build and test since we're testing for so many different platforms. I should probably add some logic to just test x86-64 Linux for non-releases. |
python3 -m pep517.check .now passesTest run https://github.com/bdraco/cChardet/actions/runs/4219774165
The extension has returned to having the modified uchardet directly linked in.
This is currently blocking Home Assistant from using this library with python 3.11 until we can get a new release with working pep517 builds.
https://github.com/home-assistant/core/actions/runs/4217296920/jobs/7320979916
Thanks for looking at this PR!