JSON grammars #49 #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure extensions are disabled when running launch. It provides us with better oversight without conflicts.
XML grammars are great but they a verbose, use JSON format grammars.
|
Expect some additional amendments to the structure of the grammers, ie: improving token definitions and moving syntaxes into a pattern based architecture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #49 here is a converted list of TextMate Grammars from XML to JSON. In addition,
--disable-extensionsflag within extension launcher.Reasoning for XML > JSON
JSON grammars are common for vscode. In addition, JSON grammars allow us to extended grammars in far less redundancy. We can also take advantage of additional vscode specific features like grammar injections with less verbosity.
Reasoning for
--disable-extensionsflagLoading up an instance of vscode without this flag will result in installed extensions from running. It is allows for a quicker load time in debug mode.