Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align schema commands with public schema endpoints #570

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Jan 17, 2025

issues: FE-6178, FE-6233

Problem

We've published the schema API, but don't use it the same way in the commands, and are not consistent between commands.

Solution

Following the published spec

  • use format instead of diff URL param.
  • do not use force. version is optional.

BONUS: fix .gitignore lines for fauna config files

Result

No change in behavior, but the code is internally consistent between commands and the published API.

Testing

We don't have integration tests, so I am a little paranoid about changing the schema endpoint calls. I ran each command with old and new code. The fauna commands are for using the current main branch, and ./src/user-entrypoint.mjs is for using this branch. schema status calls are sprinkled in with the context.

schema pull

image

schema push

image

schema abandon

image

schema commit

image

schema diff

image
image

@ptpaterson ptpaterson requested a review from a team as a code owner January 17, 2025 14:11
@ptpaterson ptpaterson changed the title Update deprecated schema endpoint calls Align schema commands with public schema endpoints Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant