-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beta support for export commands #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
requested review from
echo-bravo-yahoo,
ptpaterson,
mwilde345,
cleve-fauna and
henryfauna
January 16, 2025 21:25
cleve-fauna
approved these changes
Jan 16, 2025
mwilde345
approved these changes
Jan 16, 2025
mwilde345
reviewed
Jan 16, 2025
|
||
const INITIAL_INTERVAL_MS = 1000; // 1 second | ||
const MAX_INTERVAL_MS = 1000 * 60 * 5; // 5 minutes | ||
const MAX_WAIT_MINS = 60 * 2; // 2 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Account API will soon support export APIs, and we want the CLI to surface those APIs.
Solution
Add 3 commands to support basic export functionality available in the Account API:
fauna export create s3
: Create an export and send it to an S3 bucket.fauna export list
: List exports for the currently signed in user.fauna export get <id>
: Get the details of a current export by ID.--wait
flag tocreate
andget
. This flag will prevent the commands from exiting until the export is in a terminal state (such as complete or failed).Result
fauna export create s3
fauna export create s3
with--wait
fauna export list
fauna export get
Testing
Tests were added for the API and command changes.