Handle network errors with better messaging #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a network error occurs in the v10 driver, we get a "The network encountered a problem" message. If fetch fails, you get a "fetch failed". Neither of these are helpful.
Solution
Catch them with slightly better messaging and centralize the messaging so we are consistent in the places we need to handle these errors. Given the most likely cause of a network error is
--local
, add a blurb about that too.All commands are covered by this messaging, but may display them differently depending on their error handling.
Result
Testing
Unit tests.