Fail the shell fast if you cannot query the database #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
requested review from
echo-bravo-yahoo,
ptpaterson,
wildemat and
cleve-fauna
ptpaterson
approved these changes
Dec 11, 2024
cleve-fauna
reviewed
Dec 11, 2024
| export const isQueryable = async (argv) => { | ||
| const runQueryFromString = container.resolve("runQueryFromString"); | ||
| try { | ||
| await runQueryFromString("1+1", argv); |
cleve-fauna
approved these changes
Dec 11, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you have an invalid database or something wacky with your secret, you won't know until you run the first command in your shell.
Solution
Instead, do a quick queryable check and throw a validation error if the db is unqueryable for whatever reason. This will also exercise creds checking so that will fail fast too.
Additionally, 404s from frontdoor are thrown as
ValidationErrornow since that happens outside the scope ofisQueryable.Result
Shell will fail immediately if you cannot query the database or with the secret you've provided.
Testing
isQueryableis injected into the container, and we have a unit test to prove things fail.