Render errors as-is if they already have ansi characters #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a command throws an error message that has already been formatted for display, we clobber it and make it red. This means some errors, such as query syntax errors, lose the benefit of code highlighting.
Solution
Detect if a thrown error has been formatted for display already, and don't apply
chalk.red
if it has.While I was here, I moved the error handling code into a single module for discoverability and eventually testing.
Result
Doesn't have ansi so it renders red:

Has ansi so we display as-is:
