handle accountKey arg with user and secret #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryfauna
approved these changes
Dec 10, 2024
ptpaterson
reviewed
Dec 10, 2024
| keySource = "--secret"; | ||
| keySource = "user"; |
There was a problem hiding this comment.
So this is this describing that the source of the key is a user-provided value? Not that specifically the --user arg was provided, correct?
jrodewig
approved these changes
Dec 10, 2024
src/lib/auth/credentials.mjs
Outdated
|
|
||
| if (argv.user && argv.accountKey) { | ||
| logger.debug( | ||
| "Both 'user' and 'account-key' arguments were specified. 'account-key' will be used to mint database secrets. 'user' will be ignored.", |
There was a problem hiding this comment.
We use --accountKey in the help, but it looks like we accept both. I'll update the docs, but it may be good if our help hints output both or just the kebab-case version if that's preferred.
There was a problem hiding this comment.
put it back to camelcase for simplicity
Co-authored-by: James Rodewig <[email protected]>
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6231
Problem
user,secret, andaccount-keyarguments together without any messaging as to what is happening. This isn't clear on what is being used.Solution
secretandaccount-key. Make it clear that if they specify an account key, they are buying in to using the automatic short term database secrets we generate.userandaccount-key, but provide a debug log that we will ignoreuser.useralways gets a value of at leastdefault, so we don't want to yell about that.account-keydescriptionResult
Testing