Update use of schema API for the pull command #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
changed the title
ecooper
approved these changes
Dec 10, 2024
ecooper
reviewed
Dec 10, 2024
src/commands/schema/pull.mjs
Outdated
|
|
||
| logger.debug( | ||
| `Pulling remote ${source} schema, version '${version}'.`, | ||
| "schema pull", |
There was a problem hiding this comment.
@echo-bravo-yahoo do we have a preference of these being one word to simplify passing them?
There was a problem hiding this comment.
yeah i don't think it would work as expected unless it was a single or hyphenated word
mwilde345
approved these changes
Dec 10, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6228
Problem
We do not pass in the
versionorstagedparams to calls to get schema files.Pulling active schema while a staged schema exists is possible, but we block it.
Solution
Pass in the version and staged parameters to
/schema/1/files/{filename}endpoint calls.Update the confirmation message to indicate whether you are going to pull from active or staged schema.
Result
We can pull schema, whether it's staged or not. We utilize OCC with schema versions correctly.
Testing
Added tests that cover usage with the new behavior, including the --staged option.