Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't compute role from key name string when calling frontdoor #493

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

wildemat
Copy link
Contributor

@wildemat wildemat commented Dec 9, 2024

Ticket(s): FE-6220

Problem

When creating a Just-in-time key, we get the role from the keyName which includes a delimiter between path and role. This delimiter can be used in the user's input database to break the command.

Solution

Don't rely on delimiter. Store the users input database as path, and keep it separate from the role.

Result

Path and role are kept separate when calling frontdoor

Testing

Updated credentials test

@wildemat wildemat requested a review from a team as a code owner December 9, 2024 16:53
@wildemat wildemat merged commit 40242a4 into v3 Dec 9, 2024
4 checks passed
@wildemat wildemat deleted the fe-6220 branch December 9, 2024 21:21
@wildemat wildemat mentioned this pull request Dec 10, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants