Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "extra" option to "raw" #490

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Rename "extra" option to "raw" #490

merged 5 commits into from
Dec 10, 2024

Conversation

ptpaterson
Copy link
Contributor

Problem

"raw" may not be a perfect name for this option, but I believe it is a step forward from "extra"

Solution

rename the option and all the argv values from "extra" to "raw"

Result

no functional changes, just the name.

Testing

no functional changes, just the name.

@ptpaterson ptpaterson requested review from ecooper and a team December 6, 2024 21:05
@ptpaterson ptpaterson changed the base branch from main to v3 December 6, 2024 21:05
Copy link

@ecooper ecooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth saying it's the data from the JS drivers?

I know there's been some confusion/expectation it would be the raw http body.

@ptpaterson ptpaterson merged commit 53bf7cc into v3 Dec 10, 2024
4 checks passed
@ptpaterson ptpaterson deleted the extra-raw branch December 10, 2024 13:05
@ptpaterson
Copy link
Contributor Author

Maybe it's worth saying it's the data from the JS drivers?
I know there's been some confusion/expectation it would be the raw http body.

Like in the help description? Or via name convention?

I think it would be nice to have the option to return the wire protocol, but I otherwise like the consistency with returning the data field in the QuerySuccess object in whatever format you would have received without the --extra/--raw option.

@wildemat wildemat mentioned this pull request Dec 10, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants